Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace empty CBRN CaseMetadata and DataFileMetadata elements #24

Closed
cdmgtri opened this issue May 17, 2023 · 2 comments
Closed

Replace empty CBRN CaseMetadata and DataFileMetadata elements #24

cdmgtri opened this issue May 17, 2023 · 2 comments
Assignees
Milestone

Comments

@cdmgtri
Copy link
Contributor

cdmgtri commented May 17, 2023

CBRN defines two metadata elements, cbrn:CaseMetadata and cbrn:DataFileMetadata, which are both of type structures:MetadataType. This type is meant to be used as a parent type and not the type of a property, and the NDR is being updated accordingly for 6.0.

  • cbrn:CaseMetadata (structures:MetadataType) is contained under type cbrn:CBRNECaseType
  • cbrn:DataFileMetadata (structures:MetadataType) is contained under type cbrn:DataFileType

Recommendation options:

  1. Change the types of these properties from structures:MetadataType to nc:MetadataType, or
  2. Remove these custom properties since they do not have any specialized content and replace where they are currently being used with property nc:Metadata
@cdmgtri cdmgtri self-assigned this May 17, 2023
@cdmgtri
Copy link
Contributor Author

cdmgtri commented Sep 14, 2023

Harmonization Subcommittee recommends changing the type to nc:MetadataType.

cdmgtri added a commit to cdmgtri/niemopen-model that referenced this issue Sep 18, 2023
@cdmgtri cdmgtri added this to the 6.0-psd01 milestone Sep 23, 2023
@cdmgtri
Copy link
Contributor Author

cdmgtri commented Sep 23, 2023

Merged into the dev branch for 6.0.

@cdmgtri cdmgtri closed this as completed Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant