Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leaveOpen overloads for SepWriterOptions.To via dispose action to ctor (minor breaking changes) #123

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

nietras
Copy link
Owner

@nietras nietras commented Apr 10, 2024

  • Internalize SepWriter constructor and change the signature of the ctor
  • Mark SepWriter as sealed
  • Privatize SepWriter.Dispose(bool)

@nietras nietras changed the title Add SepWriterOptions.To extension leaveOpen overloads via dispose action to ctor (minor breaking change) Add SepWriterOptions.To leaveOpen overloads via dispose action to ctor (minor breaking change) Apr 10, 2024
@nietras nietras changed the title Add SepWriterOptions.To leaveOpen overloads via dispose action to ctor (minor breaking change) Add SepWriterOptions.To leaveOpen overloads via dispose action to ctor (minor breaking changes) Apr 10, 2024
@nietras nietras changed the title Add SepWriterOptions.To leaveOpen overloads via dispose action to ctor (minor breaking changes) Add leaveOpen overloads for SepWriterOptions.To via dispose action to ctor (minor breaking changes) Apr 10, 2024
@nietras nietras merged commit b17b330 into main Apr 10, 2024
26 checks passed
@nietras nietras deleted the writer-leaveopen branch April 10, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant