Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cxfreeze options #40

Merged
merged 2 commits into from
May 24, 2024
Merged

Fix cxfreeze options #40

merged 2 commits into from
May 24, 2024

Conversation

aokumasan
Copy link
Member

@aokumasan aokumasan commented May 22, 2024

Summary

  • Upgrade cx-freeze to 6.15.16
  • Add upgrade_code option to remove old version before installing new one.
    • The value is randomly generated code.
  • Refactor cx-freeze configs.

Tests

NOTE: these commands must be run on Windows PC.

  • python -m venv .venv
  • source .venv/Scripts/activate (if using git bash)
  • pip install pipenv==2023.5.19 setuptools wheel && pipenv install -d --skip-lock --system
  • python setup.py build
  • python setup.py bdist_msi
  • start dist
  • Run installer and install cli successfully.

Add upgrade_code to remove previous version before installing new one.
Copy link
Contributor

@tunakyonn tunakyonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍋

@tunakyonn tunakyonn merged commit 1d1abcb into main May 24, 2024
12 checks passed
@tunakyonn tunakyonn deleted the fix-cxfreeze branch May 24, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants