Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update dependencies to fix vulnerability #26

Merged
merged 10 commits into from
Apr 26, 2019

Conversation

aokumasan
Copy link
Member

@aokumasan aokumasan commented Apr 23, 2019

Summary

  • Upgrade botocore and awscli versions to fix below vulnerability.
    • urllib3
    • Jinja2
  • pyyaml is not upgraded in this p-r, because awscli depends on pyyaml 3.x (please see https://github.com/aws/aws-cli/blob/1.16.144/setup.py#L31)
  • jessie-updates apt repository was expired, so upgraded docker image version.
  • Delete Pipfile.lock to support multiple python version for development.

Review

  • docker-compose build
  • vim .env
AWS_ACCESS_KEY_ID=
AWS_SECRET_ACCESS_KEY=
AWS_DEFAULT_REGION=
  • docker-compose run --rm app python scripts/nifcloud-debugcli computing describe-instances
  • docker-compose run --rm app bash
  • (in container) pip install .
  • (in container) nifcloud-debugcli computing describe-instances

@aokumasan aokumasan force-pushed the fix/update_dependencies_to_fix_vulnerability branch from d5368c8 to 6e38558 Compare April 26, 2019 04:20
Copy link
Contributor

@sato-mh sato-mh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sato-mh sato-mh merged commit 8395bcd into master Apr 26, 2019
@aokumasan aokumasan mentioned this pull request Apr 26, 2019
@aokumasan aokumasan deleted the fix/update_dependencies_to_fix_vulnerability branch May 14, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants