Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix document base url: cloud.nifty.com -> pfs.nifcloud.com #37

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Fix document base url: cloud.nifty.com -> pfs.nifcloud.com #37

merged 1 commit into from
Apr 2, 2020

Conversation

aokumasan
Copy link
Member

Summary

  • ドメイン移行に伴い、ドキュメントサイトのドメインを新ドメインに更新しました。

@tily
Copy link
Member

tily commented Apr 2, 2020

Confirmed that the generated HTMLs contain pfs.nifcloud.com links instead of cloud.nifty.com ones:

$ docker-compose run --rm app bash -c "cd docs && make html"
(Output ommited)
$ grep -r cloud.nifty.com docs/build/ | wc -l
0
$ grep -r pfs.nifcloud.com docs/build/ | wc -l
595

tily
tily approved these changes Apr 2, 2020
View reviewed changes
Copy link
Member

@tily tily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@tily tily merged commit c100947 into master Apr 2, 2020
@aokumasan aokumasan deleted the fix/document_base_url branch August 3, 2020 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tily tily tily approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aokumasan @tily