Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Registration : RNA_def_property_ui_text description ends in '.' #246

Closed
neomonkeus opened this issue Apr 24, 2016 · 3 comments · Fixed by #467
Closed

UI Registration : RNA_def_property_ui_text description ends in '.' #246

neomonkeus opened this issue Apr 24, 2016 · 3 comments · Fixed by #467
Assignees
Labels
Beginner Good issues for someone now familiar with the code or an easy fix Error Failure scenario resulting in an error message that should not be seen but operation completes fully Usability Improvement/impact to make the plugin easier to use User Interface Improve/impact how the user interacts with the plugin via Blender UI

Comments

@neomonkeus
Copy link
Member

@niftools/blender-nif-plugin-reviewer

Issue Overview

Regression in UI property registration

Version Information

Blender Nif Plugin Version Info

Blender Nif Plugin v2.6.0.dev4-02-04-2016
https://www.dropbox.com/s/6r7gz3m38r83x6e/blender_nif_plugin-2.6.0a0.dev4-02.04.2016.zip?dl=0

Blender Version Info

Blender 2.77 64bit - Default installation location

Platform information

Ubuntu 15.04 64-bitt

Context

We expose Niftools specific properties in the UI.
Each Property has a description member for that NiObject property.
They are exposed as tool-tips but appear to be not created correctly.

Steps to Reproduce

  1. Launch Blender from the terminal window.

Expected Result

Startup should not contain any error messages

Actual Result

The logs are reporting errors from misconfiguration of Property descriptions.

Possible Fix

Remove the trailing "." from the descriptions

Screenshot

N/A

Logs and Files

N/A

Info Bar Output

N/A

Console Output

RNA_def_property_ui_text: 'LHMaxFriction' '' description ends with a '.' !
RNA_def_property_ui_text: 'tau' '' description ends with a '.' !
RNA_def_property_ui_text: 'damping' '' description ends with a '.' !
RNA_def_property_ui_text: 'rootnode' '' description ends with a '.' !
RNA_def_property_ui_text: 'bs_inv_x' '' description ends with a '.' !
RNA_def_property_ui_text: 'bs_inv_y' '' description ends with a '.' !
RNA_def_property_ui_text: 'bs_inv_z' '' description ends with a '.' !
RNA_def_property_ui_text: 'bs_inv_zoom' '' description ends with a '.' !
RNA_def_property_ui_text: 'bs_shadertype' '' description ends with a '.' !
RNA_def_property_ui_text: 'epsilon' '' description ends with a '.' !
RNA_def_property_ui_text: 'log_level' '' description ends with a '.' !
RNA_def_property_ui_text: 'profile_path' '' description ends with a '.' !
RNA_def_property_ui_text: 'scale_correction_import' '' description ends with a '.' !
RNA_def_property_ui_text: 'override_scene_info' '' description ends with a '.' !
RNA_def_property_ui_text: 'keyframe_file' '' description ends with a '.' !
RNA_def_property_ui_text: 'egm_file' '' description ends with a '.' !
RNA_def_property_ui_text: 'animation' '' description ends with a '.' !
RNA_def_property_ui_text: 'merge_skeleton_roots' '' description ends with a '.' !
RNA_def_property_ui_text: 'send_geoms_to_bind_pos' '' description ends with a '.' !
RNA_def_property_ui_text: 'send_detached_geoms_to_node_pos' '' description ends with a '.' !
RNA_def_property_ui_text: 'send_bones_to_bind_position' '' description ends with a '.' !
RNA_def_property_ui_text: 'apply_skin_deformation' '' description ends with a '.' !
RNA_def_property_ui_text: 'skeleton' '' description ends with a '.' !
RNA_def_property_ui_text: 'combine_shapes' '' description ends with a '.' !
RNA_def_property_ui_text: 'combine_vertices' '' description ends with a '.' !
RNA_def_struct_ui_text: 'IMPORT_SCENE_OT_nif' '' description ends with a '.' !
RNA_def_property_ui_text: 'epsilon' '' description ends with a '.' !
RNA_def_property_ui_text: 'log_level' '' description ends with a '.' !
RNA_def_property_ui_text: 'profile_path' '' description ends with a '.' !
RNA_def_property_ui_text: 'scale_correction_export' '' description ends with a '.' !
RNA_def_property_ui_text: 'game' '' description ends with a '.' !
RNA_def_property_ui_text: 'animation' '' description ends with a '.' !
RNA_def_property_ui_text: 'smooth_object_seams' '' description ends with a '.' !
RNA_def_property_ui_text: 'bs_animation_node' '' description ends with a '.' !
RNA_def_property_ui_text: 'stripify' '' description ends with a '.' !
RNA_def_property_ui_text: 'stitch_strips' '' description ends with a '.' !
RNA_def_property_ui_text: 'flatten_skin' '' description ends with a '.' !
RNA_def_property_ui_text: 'skin_partition' '' description ends with a '.' !
RNA_def_property_ui_text: 'pad_bones' '' description ends with a '.' !
RNA_def_property_ui_text: 'max_bones_per_partition' '' description ends with a '.' !
RNA_def_property_ui_text: 'max_bones_per_vertex' '' description ends with a '.' !
RNA_def_property_ui_text: 'force_dds' '' description ends with a '.' !
RNA_def_struct_ui_text: 'EXPORT_SCENE_OT_nif' '' description ends with a '.' !

Blend File

N/A

Nif File

N/A

Similar Known Issues

#244

Additional Information

N/A

@neomonkeus neomonkeus added User Interface Improve/impact how the user interacts with the plugin via Blender UI Usability Improvement/impact to make the plugin easier to use Error Failure scenario resulting in an error message that should not be seen but operation completes fully labels Apr 24, 2016
@neomonkeus neomonkeus added this to the v2.6.0a0.dev4 milestone Apr 24, 2016
@neomonkeus neomonkeus self-assigned this Apr 24, 2016
@neomonkeus neomonkeus modified the milestones: v2.6.0a0.dev5, v2.6.0a0.dev4 Apr 24, 2016
@neomonkeus neomonkeus added this to In progress in Blender 2.8 Support Apr 22, 2020
@neomonkeus neomonkeus moved this from In progress to To do in Blender 2.8 Support Apr 22, 2020
@neomonkeus neomonkeus removed this from To do in Blender 2.8 Support Dec 13, 2020
@HENDRIX-ZT2
Copy link
Contributor

Although the warning is no longer printed when I start blender from the console, this is still valid, resulting in the affected descripitions appearing with two dots in the UI. An easy fix, though.

@neomonkeus neomonkeus added the Beginner Good issues for someone now familiar with the code or an easy fix label Oct 4, 2021
@neomonkeus
Copy link
Member Author

I thought I had this already tagged with beginner.

HENDRIX-ZT2 added a commit to HENDRIX-ZT2/blender_niftools_addon that referenced this issue Oct 4, 2021
HENDRIX-ZT2 added a commit that referenced this issue Oct 4, 2021
Remove trailing dots for descriptions and UI items - closes #246
@HENDRIX-ZT2
Copy link
Contributor

Aaand it did not autoclose, despite "closes"... 🙈

Usability - Custom Properties Handling automation moved this from TODO to Complete Oct 4, 2021
Usability - User Interface automation moved this from TODO to Done Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Beginner Good issues for someone now familiar with the code or an easy fix Error Failure scenario resulting in an error message that should not be seen but operation completes fully Usability Improvement/impact to make the plugin easier to use User Interface Improve/impact how the user interacts with the plugin via Blender UI
Development

Successfully merging a pull request may close this issue.

2 participants