Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for the animation system #463

Merged
merged 5 commits into from
Sep 26, 2021
Merged

Conversation

HENDRIX-ZT2
Copy link
Contributor

@HENDRIX-ZT2 HENDRIX-ZT2 commented Sep 26, 2021

@niftools/blender-niftools-addon-reviewer

Overview

Various critical bug fixes for the animation system.

Detailed Description

  • kf import is unbroken
  • kf export using NiStringPalettes for controller links (FO / oblivion / ...) is fixed
  • NiTransformInterpolator default transform is set to bind pose rather than 0; if controller is keyframed, the data is now always set as interpolator data

Fixes Known Issues

#432
#458

Documentation

na

Testing

Export KF for FO3, NiTransformInterpolator transform is correctly set to bind pose, names are set, can import back again.

Manual

[Set of steps to manually verify updates are working correctly]

Automated

[List of tests run, updated or added to avoid future regressions]

Additional Information

[Anything else you deem relevant]

Was bugged due to FPS property being moved around.
@HENDRIX-ZT2 HENDRIX-ZT2 changed the title Store bind pose on NiTransformInterpolator - closes #458 Fixes for the animation system Sep 26, 2021
@HENDRIX-ZT2 HENDRIX-ZT2 added this to To do in Animation System via automation Sep 26, 2021
@HENDRIX-ZT2 HENDRIX-ZT2 merged commit 34514d3 into niftools:develop Sep 26, 2021
Animation System automation moved this from To do to Done Sep 26, 2021
@neomonkeus neomonkeus mentioned this pull request Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants