Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hfloat and html report fixes #21

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

figment
Copy link

@figment figment commented Nov 21, 2015

Add support for hfloat (not IEEE 754-2008 compliant)
Fix html report for python 3

@neomonkeus neomonkeus added this to the Version 2.2.4 milestone Feb 17, 2016
@psi29a
Copy link
Member

psi29a commented Jan 14, 2017

This would allow for using the latest nif.xml file which included hfloat. :)

@neomonkeus
Copy link
Member

neomonkeus commented Jan 16, 2017

Check out my branch here - develop...neomonkeus:hfloat
It has some required additions that I would want to have included along with this.

Regarding usage of latest nif.xml. It breaks in several other areas unfortunately. I think we would need to sync up with @jonwd7. There are probably several other refactors by jon that need to be included into the @niftools/nifxml so need to plan those changes. Ideally we would want a phased nif.xml version officially. i.e add support for hfloat and other types first. then apply usage, with the eventual goal of the niftools version converging back to the version jon uses now for @niftools/NifSkope

@3blake7
Copy link

3blake7 commented Mar 29, 2018

i know this is a work-in-progress, i just wanted to let y'all know that I patched the latest source from git with the commits above and latest nif.xml. i no longer get the hfloat error. i am using niftoaster with the check_centerradius spell, which runs on my nifs without any errrors but the bounding spheres which have vertices outside the shell are not updated and the timestamps on the nifs is unchanged.

@neomonkeus
Copy link
Member

@fractalfederation Although this would update add the base support to read the block into memory, the way the BSTriShape stores the vertex data probably would require the spell to be updated also. Will update your ticket to track that as needing to be done.

@JayFoxRox
Copy link

What's the status on this?

While I don't care about hfloat, I would still like to use the latest nif.xml.
It's a bit annoying to backport changes / bugfixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants