Fix/doc tests #35
Merged
Fix/doc tests #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Known issue :
reading tests/nif/test_opt_dupgeomdata.nif
+ Warning: read failed due corrupt file, corrupt format description, or bug.
Depending on where it is run, it could be within the module so would return __init__ or could be run a package level where it would have full pyffi.format.cfg path.
Updated to use recursive directory lookup because windows python decides to do things differently
…see if it is picked up correctly.
psi29a
reviewed
Feb 28, 2017
| # 'tests/nif/opt_vertex_cache.txt', | ||
|
|
||
| # 'tests/kfm/kfmtoaster.txt', | ||
| # 'docs-sphinx/intro.rst', |
There was a problem hiding this comment.
Yes, same issues as previous. These text files are a way to define doctests external to the source code. They also suffer from relative path issues if run from this context and also have general failures.
| @@ -57,39 +59,46 @@ | |||
| suite = unittest.TestSuite() | |||
| for mod in mods: | |||
| try: | |||
| suite.addTest(doctest.DocTestSuite(mod)) | |||
| pass | |||
| #suite.addTest(doctest.DocTestSuite(mod)) | |||
There was a problem hiding this comment.
Yes, they are currently excluded as they will fail when not run from a local context
|
@psi29a are you happy with the review? |
|
I am, we can build on this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@niftools/pyffi-reviewers
Overview
Incremental increases in test suite execution working towards all tests being executed.
Consolidation of test structure to support above.
Fixes Known Issues
N/A
Documentation
Holding off on docs until we take a decision if we can co-execute automation tests that run pytest via Travis/Appvoyer and local tests executing via doc tests.
Testing
Expanded number of tests suite being executed.
Performed maintenance updates on doctests.
Structural improvements, i.e moved files around the place to mirror prod structure better.
Manual
All manual tests mainly relate to tests run via doctests.
So...bonus coverage awaits if we can get these included in automation.
The reason not included as part of this PR is :
They aren't currently run via the pytest automation as they would break due to relative path issues.
At a later stage, attempt to figure if it is worth unifying how they run together through local execution, relative.
Automated
Additional Information
The process of introducing more tests will be incremental, but I think there is enough content.
These maybe replaced at a later stage as paths are not very well supported.
This does not contribute to current coverage for automation.