Improve/Clean sphinx related code #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change build_docs from print into raise exception - Tell coverage not to cover BuildDoc class - Remove sphinx conf.py test code - Update sphinx conf.py paths
neomonkeus
approved these changes
Nov 27, 2017
neomonkeus
added a commit
to neomonkeus/pyffi
that referenced
this pull request
Nov 17, 2019
Previous HEAD position was f265c56 Merge pull request niftools#48 from Ghostwalker71/fix/extravectorflags HEAD is now at d81d1f4 Merge pull request niftools#75 from jonwd7/develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@niftools/pyffi-reviewer
Overview
Add some of the improvements mentioned in #46 that wasn't implemented before the merge.
So that it fails the travis build when the docs aren't buildable
The BuildDoc class isn't required to be documented.
Fixes Known Issues
None
Documentation
No BuildDoc coverage
Testing
Nothing important changed, all code should be working fine.
Manual
python -m pip uninstall sphinx python setup.py build_docsAutomated
No new errors were created.
Additional Information
Please do not merge this request until I say so please. I wish to see if I can fix some sphinx build errors first.
Do tell me what you would like improved/fixed/remove!