Python 3.7 support #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace `raise StopIteration` by `return` https://www.python.org/dev/peps/pep-0479/#examples-of-breakage - replace time.clock() by time.time() since we don't really care which time it is but the latter still works
We can keep the original formatting of attribute names. snakeCase broke access to enum attributes in the blender plugin.
add a setter function and implicit access to the x,y,z properties
should do the trick
|
Merging for now with known limitations around generators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@niftools/pyffi-reviewer
Overview
Replaces expressions that are deprecated in 3.7 by stuff that works in all versions. Also adds small enhancements / fixes.
Fixes Known Issues
none
Documentation
none
Testing
none
Manual
none
Automated
none
Additional Information
none