Patch 1: fix of the issue 205 + better GLU instanciation #207
Conversation
Partial fix of the issue 205: #205
Uses GLUgl2 instead of GLU to benefit of a full implementation
Uses GLU.createGLU(GL).
Same mistake than in JoglGL...
ghost
mentioned this pull request
|
@gouessej Thanks for the fix. It used to be the way you said but I changed it during refactoring of the entire rendering system. I'm not a JOGL expert, but nothing I read suggested this was bad practice. It's good to know though! |
|
Hi. I think I put a note about that into the official JOGL user's guide and no actively maintained API based on JOGL stores GL instances. Everybody can make mistakes, don't worry. Brian discovered your mistake and talked to me about that last night. If you have any doubt on anything about JOGL, let me know and please keep up the good work :) Only people who do nothing never make mistakes. |
|
@3xp0n3nt I really mention this bad practice in the user guide, at the last paragraph in the subsection entitled "Writing a GLEventListener": http://jogamp.org/jogl/doc/userguide/#joglapi I even discourage passing the GL instance (someone else edited my changes), just fetch a fresh instance every time you need one. |
Patch 1: fix of the issue 205 + better GLU instanciation
|
@gouessej Thanks for the advice and the link! Aaron Mahan On Fri, Jan 24, 2014 at 12:53 PM, void256 notifications@github.com wrote:
|
No description provided.