Update kinobi version #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelvanderwaal
previously approved these changes
Mar 5, 2024
|
I'm a little concerned about the CLI actually being in a workspace with the other crates but we can try it and see how it works. I scanned the Kinobi changes but am not really in a position to properly check them. Everything seems to build and generate fine in a brand new repo tho, so lgtm. The new update typescript helper is a great improvement in usability! |
|
I noticed that this structure is both faster to build and uses less space since the dependencies get "shared" across the different crates. |
samuelvanderwaal
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.