Fix WHERE in autoload

nigelhorne · Dec 6, 2019 · f5ce530 · f5ce530
1 parent 471d9fc
commit f5ce530
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/lib/Geo/Coder/Free/DB.pm b/lib/Geo/Coder/Free/DB.pm
@@ -543,26 +543,30 @@ sub AUTOLOAD {
 	my %params = (ref($_[0]) eq 'HASH') ? %{$_[0]} : @_;
 
 	my $query;
+	my $done_where = 0;
 	if(wantarray && !delete($params{'distinct'})) {
 		if(($self->{'type'} eq 'CSV') && !$self->{no_entry}) {
 			$query = "SELECT $column FROM $table WHERE entry IS NOT NULL AND entry NOT LIKE '#%'";
+			$done_where = 1;
 		} else {
 			$query = "SELECT $column FROM $table";
 		}
 	} else {
 		if(($self->{'type'} eq 'CSV') && !$self->{no_entry}) {
 			$query = "SELECT DISTINCT $column FROM $table WHERE entry IS NOT NULL AND entry NOT LIKE '#%'";
+			$done_where = 1;
 		} else {
 			$query = "SELECT DISTINCT $column FROM $table";
 		}
 	}
 	my @args;
 	while(my ($key, $value) = each %params) {
 		if(defined($value)) {
-			if(scalar(@args) || ($self->{'type'} eq 'CSV')) {
+			if($done_where) {
 				$query .= " AND $key = ?";
 			} else {
 				$query .= " WHERE $key = ?";
+				$done_where = 1;
 			}
 			push @args, $value;
 		} else {