Added t/strict.t

MANIFEST

@@ -29,6 +29,7 @@ t/pod.t
 t/port.t
 t/snippets.t
 t/spelling.t
+t/strict.t
 t/translate.t
 t/unused.t
 t/vars.t

lib/Locale/Places.pm

@@ -133,11 +133,12 @@ sub translate {
 			return $line->{'data'};
 		}
 	} elsif(scalar(@places) > 1) {
-		foreach my $p(@places) {
-			if(my $line = $self->{'gb'}->fetchrow_hashref({ type => $to, code2 => $p->{'code2'} })) {
-				return $line->{'data'};
-			}
-		}
+		Carp::croak(__PACKAGE__, "Database has more than one preferred entry for $place in language $to");
+		# foreach my $p(@places) {
+			# if(my $line = $self->{'gb'}->fetchrow_hashref({ type => $to, code2 => $p->{'code2'} })) {
+				# return $line->{'data'};
+			# }
+		# }
 	}
 	return;	# undef
 }

t/carp.t

@@ -3,7 +3,7 @@
 use strict;
 use warnings;
 use Test::Carp;
-use Test::Most tests => 9;
+use Test::Most tests => 10;
 
 BEGIN {
 	use_ok('Locale::Places');
@@ -28,4 +28,6 @@ CARP: {
 
 	does_carp_that_matches(sub { $places->translate('London') }, qr/can't work out which language to translate to/);
 	does_carp_that_matches(sub { $places->translate({ place => 'London', to => 'y' }) }, qr/can't work out which language to translate from/);
+
+	does_carp_that_matches(sub { $places->translate(place => 'Dover', from => undef) }, qr/usage/);
 }

t/gb.t

@@ -1,6 +1,6 @@
 #!perl -wT
 
-# Check the GBN database is sensible
+# Check the GB database is sensible
 
 use strict;
 use warnings;

t/strict.t

@@ -0,0 +1,20 @@
+#!perl -w
+
+use strict;
+use warnings;
+
+use Test::Most;
+
+if($ENV{AUTHOR_TESTING}) {
+	eval 'use Test::Strict';
+	if($@) {
+		plan(skip_all => 'Test::Strict required for testing use strict');
+	} else {
+		all_perl_files_ok();
+		warnings_ok('lib/Locale/Places.pm');
+		warnings_ok('lib/Locale/Places/DB.pm');
+		warnings_ok('lib/Locale/Places/DB/GB.pm');
+	}
+} else {
+	plan(skip_all => 'Author tests not required for installation');
+}