Skip to content

Commit

Permalink
fix: better type markup
Browse files Browse the repository at this point in the history
  • Loading branch information
nigelm committed Feb 7, 2022
1 parent 7fef38e commit 89a9446
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions broadworks_ocip/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ def etree_sub_element_(
elem.text = value

@classmethod
def column_header_snake_case_(cls, header:str)->str:
def column_header_snake_case_(cls, header: str) -> str:
"""
Converts an XML name into a pythonic snake case name
Expand All @@ -234,7 +234,7 @@ def column_header_snake_case_(cls, header:str)->str:
"""
return re.sub("[ _]+", r"_", header).lower()

def snake_case_to_column_header(self, snake_str:str)->str:
def snake_case_to_column_header(self, snake_str: str) -> str:
"""
Converts a pythonic snake case name into a column header name
Expand All @@ -250,7 +250,7 @@ def snake_case_to_column_header(self, snake_str:str)->str:
return " ".join(x.title() for x in components)

@classmethod
def decode_table_(cls, element: "etree._Element")->List[NamedTuple]:
def decode_table_(cls, element: "etree._Element") -> List[NamedTuple]:
"""
Decode a table (used in a OCIResponse) into a list of named tuples
Expand All @@ -261,12 +261,12 @@ def decode_table_(cls, element: "etree._Element")->List[NamedTuple]:
results: List of namedtuple elements, one for each table row
"""
typename: str = element.tag
results = []
results: List[NamedTuple] = []
columns = [
cls.column_header_snake_case_(b.text)
for b in element.iterfind("colHeading")
]
type = namedtuple(typename, columns) # type: ignore
type: NamedTuple = namedtuple(typename, columns) # type: ignore
for row in element.iterfind("row"):
rowdata = [b.text for b in row.iterfind("col")]
rowobj = type(*rowdata)
Expand All @@ -278,7 +278,7 @@ def build_from_etree_non_parameters_(
cls,
element: "etree._Element",
initialiser: dict,
)->None:
) -> None:
"""
Handle any items outside the parameter set
Expand Down

0 comments on commit 89a9446

Please sign in to comment.