-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fiat currency; fixes for running on Apple Silicon #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review completed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! awesome feature!.
I have left blocking and non-blocking comments that might be resolved with code, clarifying comments or TODOs with future issues to be resolved later.
modules/Sources/Features/Home/NighthawkSettings/Fiat/FiatView.swift
Outdated
Show resolved
Hide resolved
Thank you, @pacu, for your invaluable and timely code reviews, especially as we approach Nighthawk's public release. However, it's important to note that the 2023 grants committee has unanimously voted to reject the wallet maintenance proposal, following an already partially approved budget for our team. This decision poses challenges for Nighthawk developers ability to meeting user needs. We encourage you to contribute by opening a pull request to the project if you have ideas or solutions. |
modules/Sources/Dependencies/SDKSynchronizer/SDKSynchronizerLive.swift
Outdated
Show resolved
Hide resolved
I'm sorry that you folks didn't get that grant :(. I will continue contributing to NH's codebase for sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for taking in my feedback!
utACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer