-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable change server (app relaunch required); various bugfixes #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self-review complete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty neat. I know app relaunch is not the most elegant but is certainly the most simple to implement, less error prone and a good trade-off in terms of the changes that a "hot swap" would need.
I only left one thing which is unrelated to the specifics of this PR, but that might be introducing some edge case that is worth testing manually.
👍
@@ -103,8 +103,7 @@ public struct SendFlow: Reducer { | |||
public var hasEnteredAmount: Bool { amountToSend > .zero } | |||
public var hasEnteredRecipient: Bool { recipient?.data.isEmpty != true } | |||
public var canSendEnteredAmount: Bool { | |||
true | |||
// amountToSend <= maxAmount | |||
amountToSend <= maxAmount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhmmm I think this is not fully accurate in terms of how the Fee is met. I'd manually test the maxAmount
case to see what happens in reality when the transaction is built and the fee is added. If you already did that, please disregard this comment
This code review checklist is intended to serve as a starting point for the author and reviewer, although it may not be appropriate for all types of changes (e.g. fixing a spelling typo in documentation). For more in-depth discussion of how we think about code review, please see Code Review Guidelines.
Author
Reviewer