Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some strings refers to closed source add-ons #12

Open
AntoineTurmel opened this issue Jun 28, 2012 · 3 comments
Open

Some strings refers to closed source add-ons #12

AntoineTurmel opened this issue Jun 28, 2012 · 3 comments
Labels
Need code Songbird issue

Comments

@AntoineTurmel
Copy link
Member

In this string, the software ask the user to install a closed-source add-on for MTP/MSC devices :

https://github.com/nightingale-media-player/nightingale-l10n/blob/master/locales/en-US/songbird/songbird.properties#L1401

We should remove those references and maybe redirect the user to the built-in FolderSync feature.
@ghost ghost assigned AntoineTurmel Jun 28, 2012
@rsjtdrjgfuzkfg
Copy link
Member

Agree. Even if we get MSC or MTP device support at some time, I assume having autoplay is a low-priority feature.

@AntoineTurmel
Copy link
Member Author

do we remove those strings ? I think we can remove them, and move all removed strings in an unused file to keep track if they decide to put things open source.

@rsjtdrjgfuzkfg
Copy link
Member

agree for the unused-strings-file, see issue #17

@AntoineTurmel AntoineTurmel removed their assignment Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Need code Songbird issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AntoineTurmel @rsjtdrjgfuzkfg