Hungarian, Italian, Portuguese and Turkish layouts #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Hungarian and Hungarian (U always up) layouts
Official Italian and Turkish layouts. The Turkish one exists only in the iOS version of MessagEase.
merge italian-and-turkish to main branch
nightkr
reviewed
Apr 5, 2024
| @@ -0,0 +1,115 @@ | |||
| package se.nullable.flickboard.model.layouts | |||
There was a problem hiding this comment.
Please add a comment to the file explaining what DT means.
| @@ -0,0 +1,115 @@ | |||
| package se.nullable.flickboard.model.layouts | |||
| @@ -0,0 +1,115 @@ | |||
| package se.nullable.flickboard.model.layouts | |||
There was a problem hiding this comment.
We don't differentiate the others on platform, I think it's fair to call this one just PTMessagEase (and treat iOS as the special case worth calling out).
| HungarianMF("Hungarian (MessagEase, by Máté Farkas)", HU_MF_MESSAGEASE), | ||
| HungarianUUp("Hungarian (MessagEase, U always up)", HU_UUP_MESSAGEASE), | ||
| Italian("Italian (MessagEase)", IT_MESSAGEASE), | ||
| PortugueseAnd("Portuguese (MessagEase, Android)", PT_AND_MESSAGEASE), |
There was a problem hiding this comment.
Suggested change
| PortugueseAnd("Portuguese (MessagEase, Android)", PT_AND_MESSAGEASE), | |
| Portuguese("Portuguese (MessagEase)", PT_AND_MESSAGEASE), |
|
Thank you for the review! I have made the changes. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed the previous pull requests, because their ordering in Settings.kt would have required manual conflict resolution. This request could be automatically merged.
Layouts in request:
Hungarian
Italian
Portuguese
Turkish