Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAPS Wear, latest dev commit#041d0f0: Ongoing bolus notification that can not be cleared. #3137

Closed
vanelsberg opened this issue Dec 22, 2023 · 6 comments

Comments

@vanelsberg
Copy link
Contributor

vanelsberg commented Dec 22, 2023

AndroidAPS 3.3.0-dev Wear application
Build: 041d0f0
Flavor: Fullrelease

Problem description:

Latest dev commit 041d0f0 (Wear: create notification channel) introduces a problem for my Samsung Watch 4 running the AAPS watchface (both stock or custom):

The watch now continuesly shows an "ongoing notification" that can not be cleared.
Forcefully clearing the notification is not possible (it immediately reopens after clearing)

ogn

@vanelsberg vanelsberg changed the title AAPS Wear, latest dev commit#8836f90 : Ongoing notification that can not be cleared. AAPS Wear, latest dev commit#8836f90 : Ongoing bolus notification that can not be cleared. Dec 22, 2023
@vanelsberg
Copy link
Contributor Author

vanelsberg commented Dec 22, 2023

Additional note:
Looks like this problem is only for bolus notifications. They stay open at 100% - Success (see screenschot)
(Bolus notification not properly closed when bolus finishes?)

Carbs notification for instance are not affected.

@vanelsberg
Copy link
Contributor Author

Additional note:
@MilosKozak Tested with previous commit f3be1bb
Problem is not in this commit.

@vanelsberg vanelsberg changed the title AAPS Wear, latest dev commit#8836f90 : Ongoing bolus notification that can not be cleared. AAPS Wear, latest dev commit#041d0f0b: Ongoing bolus notification that can not be cleared. Dec 22, 2023
@vanelsberg vanelsberg changed the title AAPS Wear, latest dev commit#041d0f0b: Ongoing bolus notification that can not be cleared. AAPS Wear, latest dev commit#041d0f0: Ongoing bolus notification that can not be cleared. Dec 22, 2023
@MilosKozak
Copy link
Contributor

ongoing notification channel is necessary to keep app running on background
you have to hide it https://www.reddit.com/r/tasker/comments/rf7369/protip_disable_specific_notification_channels_on/

@vanelsberg
Copy link
Contributor Author

vanelsberg commented Dec 24, 2023

ongoing notification channel is necessary to keep app running on background you have to hide it https://www.reddit.com/r/tasker/comments/rf7369/protip_disable_specific_notification_channels_on/

Nope, tested this but does not solve the problem? :-(
From developer mode on the watch I can disable some or all of the notification types, but as soon as there is a (bolus) notification it is an "ongoing notification" which cannot be cleared. I can disable "all", but then I do not get any notifications at all :-|

My conclusion:

  1. User being unable to clear (any) notification on the watch UI is unwanted behavior.
  2. Hiding only works when disabling all AAPS notifications on the watch, which would disable important functionality.
  3. It is rather odd to expect AAPS users to go into developer mode to hide/prevent such unexpected and unwanted behavior?

Proposed solution:

Make activating the ongoing channel a user configurable option:
As far as I know the ongoing notification channel is unexpected/unwanted behavior only necessary (as a work around?) for users running non-AAPS watchfaces.

@MilosKozak Let me know if you'd like this prosed solution moved to a separate issue.

@vanelsberg
Copy link
Contributor Author

vanelsberg commented Dec 25, 2023

@MilosKozak Did some local testing,
enabling the (ongoing) Wear: create notification channel as a user option through the wear app settings.

Code is still QAD, but could do a PR for dev's to test?

@vanelsberg
Copy link
Contributor Author

vanelsberg commented Dec 27, 2023

Confirming my problem #3137 was partly fixed through #3141

Additional info:
Still getting "Datalayer Foreground Service Channel" notification that can't be cleared (Samsung Watch4).

Solution:
Switch off this notification from watch developer options:
App Notifications -> All watch apps -> AAPS -> Data layer Foreground Service Channel: OFF

Rather odd that users should go to watch's developer mode to fully fix te problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants