Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed boken regexp in allCommitted() #3176

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

vaterlangen
Copy link

The Regexp used to allow changes in various files was broken as regexp syntax has to be casted explicitly when using string.replace() function.

Steps to reproduce:

  • Change file within .idea/codeStyles/
  • Try to build
  • FAIL due to uncommited changes

@Philoul
Copy link
Contributor

Philoul commented Jan 20, 2024

Target branch should never be master but dev branch when you make a PR...

@vaterlangen vaterlangen changed the base branch from master to dev January 20, 2024 19:21
@vaterlangen
Copy link
Author

Sorry.
Updated branch and base to dev

Copy link

sonarcloud bot commented Jan 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

20 Security Hotspots
6.3% Duplication on New Code (required ≤ 3%)
C Security Rating on New Code (required ≥ A)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@MilosKozak MilosKozak merged commit 3306e0b into nightscout:dev Jan 22, 2024
1 of 4 checks passed
@vaterlangen vaterlangen deleted the fixed_broken_regexp branch January 22, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants