Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medtrum connection issues #3331

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Medtrum connection issues #3331

merged 2 commits into from
Jun 19, 2024

Conversation

jbr7rr
Copy link

@jbr7rr jbr7rr commented May 10, 2024 •
edited
Loading

#3284

  • Check better for permissions in driver and request when attaching new patch.
  • Use deviceAddress instead of deviceObject to save the Bluetooth address for reconnects which should prevent inability to reconnect

@jbr7rr jbr7rr mentioned this pull request May 10, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jbr7rr jbr7rr marked this pull request as ready for review May 30, 2024 11:05
@jbr7rr
Copy link
Author

jbr7rr commented May 30, 2024

Open for merge, has been tested for over 2 weeks on at least 2-3 phones, no regressions

@MilosKozak MilosKozak merged commit 08ffac7 into nightscout:dev Jun 19, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbr7rr @MilosKozak