Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lane upgrade fastlane #134

Merged

Conversation

marionbarker
Copy link
Contributor

@marionbarker marionbarker commented Apr 29, 2024

The purpose of this PR is to update the branch used by PR #127 so that PR can then be merged.

  1. The Gemfile.lock modification is required to upgrade Fastlane to 2.220.0 in order to test browser build.
  2. The lane names are limited to letters and underscore. Any non-underscore character is treated as a delimiter
    • I went with build_open_iaps as the lane name for fastlane/Fastfile and for .github/workflows/build_Open-iAPS.yml

Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjornoleh bjornoleh merged commit aecc223 into nightscout:rename_scheme Apr 29, 2024
This was referenced May 1, 2024
@marionbarker marionbarker deleted the fix-lane-upgrade-Fastlane branch May 6, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants