Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the default CGM with a fresh install. #141

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix the default CGM with a fresh install. #141

merged 1 commit into from
May 3, 2024

Conversation

avouspierre
Copy link
Contributor

Start with “none” as CGM type allowing to have the icon “Add CGM”.

@avouspierre
Fix the default CGM with a fresh install.
14f5030 
Start with “none” as CGM type allowing to have the icon “Add CGM”.
@avouspierre avouspierre requested a review from bjornoleh May 2, 2024 06:42
@marionbarker
Copy link
Contributor

Successful Test:

  • Deleted Oi from a test phone (SE running iOS 17.4.1).
  • Applied the patch from PR 141 to alpha, commit aa55271 (Merge pull request 120 from MikePlante1/disable-smb-schedule).
  • Built as new app on the test phone.
    • Initial main screen shows: Add CGM
    • Tap on it and it show Type: None
    • Select a CGM
    • None continues to be an option for the selection.

@marionbarker marionbarker self-requested a review May 2, 2024 17:46
@bjornoleh bjornoleh changed the base branch from alpha to dev May 3, 2024 05:32
@bjornoleh bjornoleh merged commit e4a71ef into nightscout:dev May 3, 2024
@MikePlante1 MikePlante1 mentioned this pull request May 3, 2024
Draft
4 tasks
@MikePlante1 MikePlante1 mentioned this pull request Jun 16, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionbarker marionbarker marionbarker approved these changes

@bjornoleh bjornoleh bjornoleh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avouspierre @marionbarker @bjornoleh