Testflight expire date #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried to test this, but GH failed to upload the IPA. I don't think that's related to this PR at all, seems to be from removing Re-testing after restoring that line now. |
|
After applying #164 it built fine and seems to work. 
|
|
Repeating comment in both PR #163 and PR #164 because both are required. Success for Browser Build with PR 163 + 164 added to dev (including the merged PR 165).
First build failed because I inadvertently modified swiftpm/Package.resolved |
marionbarker
approved these changes
May 9, 2024
Merged
MikePlante1
approved these changes
May 9, 2024
bjornoleh
added a commit
that referenced
this pull request
May 10, 2024
Commit missing details for #163
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculation of expiration date that handles xcode and browser/testflight.
Refactoring of Branch/Tag/sha storage, using the BuildDetails.plist instead of branch.txt
Resolves: #153