Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_trio.yml: use actions/upload-artifact@v4 #179

Merged
merged 1 commit into from
May 16, 2024

Conversation

bjornoleh
Copy link
Contributor

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024

LoopWorkspace already use actions/upload-artifact@v4

actions/upload-artifact@v3 is scheduled for deprecation on November 30, 2024
Copy link
Contributor

@MikePlante1 MikePlante1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Did a test browser build for this and it was successful as expected.

Copy link
Contributor

@bjorkert bjorkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns with other browser build apps.

Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by code inspection.

@MikePlante1 MikePlante1 merged commit c25cc55 into nightscout:dev May 16, 2024
@MikePlante1 MikePlante1 mentioned this pull request May 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants