Override refactor + override in charts + override in Watch #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
fix when preset has no id
Add override options for apple watch inside the temp target menu. - allows to select a override preset (or a temp target) - allows to cancel a current override preset or specific override (idem for temp target) - add a color profil for override profil - Fix some minor code
avouspierre
requested review from
marionbarker,
MikePlante1 and
dnzxy
and removed request for
marionbarker
|
@avouspierre could there be a function that for at least a timewise unrestricted override to copy the new basal profile to the pump? |
use async to update overrideObserver.
Keep the one in Nightscout Config
- One more click to reach the service, but - Added chevron in settings list (for consistency) - Added room for information/explainations of the setting in header/footer in the new view - First draft to build on (maybe: rephrase header/footer, add connection status in navigation view, other relevant info etc)
- and remove uneccessary header
-and also tidePool* to tidepool*
- Footer text in 2 elements - spelling error fix and Connect to Tidepool from ontapgesture text -> Action button with blue text for consistency
- Sheet needed to be moved outside Form (Swift curiosity)
Treatments: Carbs and Temp Targets - and also announcements
- Imroved structure and UX workflow when configuring Nightscout settings - Added Connect, Upload, Fetch views with relevant settings per view - Import settings and backfill glucose buttons kept in rootview since they are more frequently used - Added footers for many sections to explain what the toggles actually do - Loacalizaation needed for new textstrings. Just updated that with small changes in already existing strings
- Break up long strings in several text elements (enables re-use of some already existing translations) - Change button text "Connect" to "Connect to Nightscout" in NightscoutConnectView
Display the eventual Pump Statut Highlight Message in home view if state is warning or critical. fix partially issue nightscout#207
Change statut to status variable and function
The PR includes a large refactoring of the swift part of override/profile functions : - Override is stored in override core data, including history - Override preset is stored in overridepreset core data - Add the display of the override in main graph - add the upload of override as a exercice in Nightscout - Fix nightscout#145 - improve the management of indefinate override / stop of indefinate override - modify the code to respect the Ivan’s patterns of the app : - Use of swiftInject (dependency injection) with the use of protocol class in the code - Use of MVP principes, in particular not use of direct coredata in view class - Use of a proxy model class between coredata and the app to manage changes of core data - Use of the pattern of observe to refresh data/view/uploads - add a core data unit tests allowing to add tests for coredata with a in-memory datastore for tests. - test for overrideStorage available This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code. TODO : Changes the shortcuts after merging with PR nightscout#144 and add watch for overrides.
Fix a issue when you want to extend a current preset.
Add edit based on PR nightscout#235
Reduce the call of coredata for override when a observer is executed Reduce the observer update
|
This PR seems to be under active development and has elements that collide with #235 and #236 respectively. May I make two proposals:
|
OK. I create new PR with different splits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes a large refactoring of the swift part of override/profile functions :
This PR do NOT change the logic with oref and the interface of override informations in oref. This PR do NOT require a update of trio-oref code.
TODO : Changes the shortcuts after merging with PR #144 and add watch for overrides.
The PR replaces the PR #178 with the functionality for Apple Watch.