Backport HealthKit fix to earlier version

[AndreasStokholm]

I originally implemented this fix in a slightly newer version, so this is a backport. This meant that I had to make a few changes in NS and some other places to make the API compatible. The actual fix itself is what's in HealthKitManager.swift, everything else is to conform to that version of the HKM API wherever it's being called.

More specifically, the HealthKitManager fix are the following parts:

• syncID -> syncID.id: https://github.com/nightscout/Open-iAPS/compare/apple-health-fix?expand=1#diff-ad150566aaf780d912eaea022c0e727588f1d24ce1c8ee38997162e5f19c040bR256
• A switch to trusty old callback pattern instead of using sinks which would sometimes cause a crash due to reasons I have not yet fully understood. My best guess is that the reference of where to .sink it was no longer valid.

[bastiaanv]

Haven't run the code, but looks good!

[marionbarker]

In code review:

• I noticed that in several places - there is a change from "FreeAPS" (root string) to "iAPS"
• Some comments but some in code

Will this be changed to Open-iAPS?

[dnzxy]

Will this be changed to Open-iAPS?

Should be, yes. Those string changes were something I did in a very early version before Andreas‘ rewrite, where I had added more logging and the app was named iAPS back then 😂

[bjornoleh]

Will this be changed to Open-iAPS?

Should be, yes. Those string changes were something I did in a very early version before Andreas‘ rewrite, where I had added more logging and the app was named iAPS back then 😂

I took the liberty of replacing iAPS with Open-iAPS in comments of HealthKitManager.swift :-)

Anything else missing now?

@AndreasStokholm, there is a positive review by Bastiaan above, with a minor comment about debug vs print.