Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testflight.md: Add the optional instructions for modifying automated build and sync #299

Merged

Conversation

bjornoleh
Copy link
Contributor

We skipped the optional instructions for modifying automated build and sync when previously adapting testflight.md to Trio, but we should probably include this information as well. This PR brings in the same info as is found in testflight.md in LoopWorkspace dev.

@bjornoleh bjornoleh added the documentation Improvements or additions to documentation label Jun 11, 2024
Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition matches LoopWorkspace dev branch instructions (which I wrote originally and no one has complained or reported errors.)

@marionbarker
Copy link
Contributor

marionbarker commented Jun 16, 2024

Looking back, @dnzxy and I worked together on the PR in LoopWorkspace that brought in this testflight.md along with the associated build_loop.yml change.

Copy link
Contributor

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in sync with how Loop‘s browser build works. Since Loop and Trio have feature parity in this context, LGTM.

@dnzxy
Copy link
Contributor

dnzxy commented Jun 16, 2024

Merging with two approvals.

@dnzxy dnzxy merged commit 82f2d01 into nightscout:alpha Jun 16, 2024
1 check passed
@MikePlante1 MikePlante1 mentioned this pull request Jun 25, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Jun 27, 2024
…_disable_automations

testflight.md: Add the optional instructions for modifying automated build and sync
@MikePlante1 MikePlante1 mentioned this pull request Jun 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants