Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for setting of BG Targets #321

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

Sjoerd-Bo3
Copy link
Contributor

@Sjoerd-Bo3 Sjoerd-Bo3 commented Jun 18, 2024

Implemented the iAPS fix https://github.com/Artificial-Pancreas/iAPS/pull/715/files that closes Issue #318

Signed-off-by: Sjoerd-Bo3 <sjoerd.bozon@gmail.com>
Signed-off-by: Sjoerd-Bo3 <sjoerd.bozon@gmail.com>
Signed-off-by: Sjoerd-Bo3 <sjoerd.bozon@gmail.com>
Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on testing with GH build.

Edit: Did check that there are no uncommitted changes after the build. But did not do significant code review.

Tested successfully setting mmol target values of:
4 (min)
4,1
6
6,1
6,2
10 (max)

Also tested with mg/dL units:
72 (min)
109
110
111
180 (max)

@marionbarker
Copy link
Contributor

Summary

I confirm Issue #318 is fixed with this patch

Testing

Tested by applying patch to alpha commit 82f2d01

  • built on existing Trio, SE running iOS 17.5.1
  • units already mmol/L from testing the issue earlier (see comment)
    • modify target, save, go to settings, return to target screen:
      • choose 6.0; final 6.0
      • choose 6.1; final 6.1
      • choose 6.2; final 6.2
      • choose 4.0, final 4.0
      • choose 10.0, final 10.0

@dnzxy
Copy link
Contributor

dnzxy commented Jun 19, 2024

Bandaid fix for now, we generally a more thought out handling of mmol values; handle everything in mg/dl and only display in mmol.

This fixes #318 and LGTM. Merging with 3 approvals.

@dnzxy dnzxy merged commit 7c88bac into nightscout:alpha Jun 19, 2024
@MikePlante1 MikePlante1 mentioned this pull request Jun 25, 2024
mountrcg pushed a commit to mountrcg/Trio that referenced this pull request Jun 27, 2024
@MikePlante1 MikePlante1 mentioned this pull request Jun 27, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot set a BG target of 6.1, silent reset to 4 mmol/l
4 participants