Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(projectmanagment): only run in nightscout repo, use of general token, rename #342

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

Sjoerd-Bo3
Copy link
Contributor

@Sjoerd-Bo3 Sjoerd-Bo3 commented Jul 4, 2024

This makes:

  • 'Stale Issues' and 'Add to Project' only run in the Nightscout Repo
  • Rename of 'Stale Issues' and 'Add to Project' to be add the bottom of the workflows
  • Let 'Stale Issues' use the general GH token generation. So it will be a Bot commenting on it.

@Sjoerd-Bo3 Sjoerd-Bo3 changed the title Only run in Nightscout Repo and use of general token fix(staleissues): Only run in Nightscout Repo and use of general token Jul 4, 2024
@Sjoerd-Bo3 Sjoerd-Bo3 changed the title fix(staleissues): Only run in Nightscout Repo and use of general token fix(staleissues): only run in nightscout repo and use of general token Jul 4, 2024
@Sjoerd-Bo3 Sjoerd-Bo3 marked this pull request as ready for review July 4, 2024 11:37
@Sjoerd-Bo3 Sjoerd-Bo3 changed the title fix(staleissues): only run in nightscout repo and use of general token fix(projectmanagment): only run in nightscout repo, use of general token, rename Jul 4, 2024
AndreasStokholm
AndreasStokholm previously approved these changes Jul 4, 2024
@marionbarker
Copy link
Contributor

Summary:

needs an update to the name on line 1 as shown below - remove the hyphen

name: 8. DONT RUN Add bugs to bugs project
name: 8. DONT RUN close inactive issues

Details:

Added this branch to loopdocs-tester username and then made it the default branch
Went to the Actions tab (see screenshot)
I am not able to run the add bugs action.

branch-workflow-update-01

I then tapped on the other 8. Don't run - close inactive issues (this is the one that ran automatically yesterday).
The failed run shows up. But after I deleted that log, the workflow no longer shows up.

branch-workflow-update-02

This graphic shows all workflows.

branch-workflow-update-03

I learned from @dnzxy that adding a hyphen to the name makes it treat what comes after the hyphen as an argument. I edited the two files (first lines detailed above) and here's the view in loopdocs-tester after the edit.

branch-workflow-update-04

@marionbarker marionbarker self-requested a review July 4, 2024 21:45
.github/workflows/add_to_project.yml Outdated Show resolved Hide resolved
.github/workflows/stale_issues.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@dnzxy dnzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's go 🚀

@Sjoerd-Bo3 Sjoerd-Bo3 merged commit 0049949 into dev Jul 4, 2024
1 check passed
@MikePlante1 MikePlante1 mentioned this pull request Jul 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants