Add branch name and commit hash to the "What to test" field in TestFlight #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornoleh
force-pushed
the
branch-info-in-testflight
branch
from
56282ec
to
8a76793
Compare
This was originally introduced by @MikePlante1 in iAPS Artificial-Pancreas/iAPS#360 This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before. The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC. See nightscout/Trio#23 and nightscout/Trio#63 for details
bjornoleh
force-pushed
the
branch-info-in-testflight
branch
from
8a76793
to
2fff224
Compare
|
A version of the workaround for the initial changelog is now documented in nightscout/trio-docs#22. Please note an easier workaround is possible too: Screenshots from building Loop, but the same applies to all: Click any previous build (provided you already built successfully once): Then, enter something (anything) in the Test Details fiels, and hit Save. The next time you build, the branch name and commit id should appear as test notes in TestFlight. |
bjornoleh
changed the title
|
Tested and confirmed to work in alpha and also previously in iAPS. Merging this into dev. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally introduced by @MikePlante1 in iAPS Artificial-Pancreas/iAPS#360
This PR includes a feature for uploading the branch name and git reference as a “changelog” to TestFlight, displayed under “What to Test” for each build. However , there is a bug in AppStore Connect / TestFlight, where fastlane fails to upload changelog if it was never entered before.
The workaround is to make a manual “Test Details” entry from AppStoreConnect (ASC), then build again. Then, the branch and git ref will be displayed under "What to Test" in both TestFlight and ASC.
See #23 and #63 for details.