Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic that determines npm version to use #1432

Merged

Conversation

davidebbo
Copy link
Contributor

This was caused by a bug in an older version of kuduscript (see projectkudu/KuduScript#35). The bug has been fixed for a while, but once you generate your custom deploy.sh with the bug in it, you have to hand fix it, which is what this patch does.

@codecov-io
Copy link

Current coverage is 82.66%

Merging #1432 into hotfix/node-version-azure will not affect coverage as of 1f581b6

@@            hotfix/node-version-azure   #1432   diff @@
=========================================================
  Files                              79      79       
  Stmts                            6108    6108       
  Branches                            0       0       
  Methods                             0       0       
=========================================================
  Hit                              5049    5049       
  Partial                             0       0       
  Missed                           1059    1059       

Review entire Coverage Diff as of 1f581b6


Uncovered Suggestions

  1. +0.19% via .../js/profileeditor.js#324...335
  2. +0.18% via .../js/profileeditor.js#269...279
  3. +0.16% via .../report/js/report.js#259...268
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@jasoncalabrese
Copy link
Member

Nice catch, going to merge to the hotfix branch now, and we can verify that works then get the hotfix merged to master

jasoncalabrese added a commit that referenced this pull request Dec 28, 2015
Fix logic that determines npm version to use
@jasoncalabrese jasoncalabrese merged commit 898513c into nightscout:hotfix/node-version-azure Dec 28, 2015
@amazaheri
Copy link

Awesome!

@jasoncalabrese jasoncalabrese modified the milestone: 0.9 Apr 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants