-
Notifications
You must be signed in to change notification settings - Fork 71.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove forever and dependencies giving warnings on Windows #3641
Conversation
…ible to deploy on windows
…evcenter.heroku.com/changelog-items/370 Procfile no longer required for Node.js apps A Procfile is no longer required to run a Node.js app on Heroku. If no Procfile is present in the root directory of your app during the build process, we will check for a scripts.start entry in your package.json file. If such an entry is present, a default Procfile is generated automatically)
Just ran
|
I recall Heroku refuses to run without forever? |
@jaylagorio Thanks for testing. I will probably work on this PR this weekend. @sulkaharo Running PieterGit@2d763c6 without forever since Jun 24 (~10 days) without problems, so that does not seem to be a problem. According to https://www.toptal.com/nodejs/top-10-common-nodejs-developer-mistakes it's Mistake #10: Not Using Supervisor Programs. I was hoping Heroku will be able to restart dynos by it selves. Removing |
@PieterGit Just drop me a heads up here when you've added commits I can pull down! This weekend should work for me for testing. |
@jaylagorio fixed this with #3675 |
Removing |
Confirmed |
Implemented removal of |
First step: remove forever and Procfile
Work in progress. Needs more testing.