Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forever and dependencies giving warnings on Windows #3641

Closed
wants to merge 5 commits into from

Conversation

PieterGit
Copy link
Contributor

First step: remove forever and Procfile
Work in progress. Needs more testing.

…evcenter.heroku.com/changelog-items/370

Procfile no longer required for Node.js apps A Procfile is no longer required to run a Node.js app on Heroku. If no Procfile is present in the root directory of your app during the build process, we will check for a scripts.start entry in your package.json file. If such an entry is present, a default Procfile is generated automatically)
@jaylagorio
Copy link
Contributor

Just ran npm install --msvs_version=2013 on Windows Server 2016 using this branch:

44180 silly gunzTarPerm modified mode [ 'webSocket/index.js.map', 420, 438 ]
44181 silly gunzTarPerm extractEntry webSocket/package.json
44182 silly gunzTarPerm modified mode [ 'webSocket/package.json', 420, 438 ]
44183 silly cache afterAdd rxjs@6.2.1
44184 verbose afterAdd C:\Users\user\AppData\Roaming\npm-cache\rxjs\6.2.1\package\package.json not in flight; writing
44185 verbose afterAdd C:\Users\user\AppData\Roaming\npm-cache\rxjs\6.2.1\package\package.json written
44186 verbose fstream_class Extract
44187 verbose stack Error: unexpected eof
44187 verbose stack     at decorate (C:\Program Files\nodejs\node_modules\npm\node_modules\fstream\lib\abstract.js:67:36)
44187 verbose stack     at Extract.Abstract.error (C:\Program Files\nodejs\node_modules\npm\node_modules\fstream\lib\abstract.js:61:12)
44187 verbose stack     at Extract._streamEnd (C:\Program Files\nodejs\node_modules\npm\node_modules\tar\lib\extract.js:91:35)
44187 verbose stack     at BlockStream.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\tar\lib\parse.js:51:8)
44187 verbose stack     at BlockStream.emit (events.js:104:17)
44187 verbose stack     at BlockStream._emitChunk (C:\Program Files\nodejs\node_modules\npm\node_modules\block-stream\block-stream.js:203:10)
44187 verbose stack     at BlockStream.resume (C:\Program Files\nodejs\node_modules\npm\node_modules\block-stream\block-stream.js:58:15)
44187 verbose stack     at Extract.Reader.resume (C:\Program Files\nodejs\node_modules\npm\node_modules\fstream\lib\reader.js:249:34)
44187 verbose stack     at Entry.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\tar\lib\parse.js:261:8)
44187 verbose stack     at Entry.emit (events.js:104:17)
44188 verbose fstream_stack Extract._streamEnd (C:\Program Files\nodejs\node_modules\npm\node_modules\tar\lib\extract.js:91:35)
44188 verbose fstream_stack BlockStream.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\tar\lib\parse.js:51:8)
44188 verbose fstream_stack BlockStream.emit (events.js:104:17)
44188 verbose fstream_stack BlockStream._emitChunk (C:\Program Files\nodejs\node_modules\npm\node_modules\block-stream\block-stream.js:203:10)
44188 verbose fstream_stack BlockStream.resume (C:\Program Files\nodejs\node_modules\npm\node_modules\block-stream\block-stream.js:58:15)
44188 verbose fstream_stack Extract.Reader.resume (C:\Program Files\nodejs\node_modules\npm\node_modules\fstream\lib\reader.js:249:34)
44188 verbose fstream_stack Entry.<anonymous> (C:\Program Files\nodejs\node_modules\npm\node_modules\tar\lib\parse.js:261:8)
44188 verbose fstream_stack Entry.emit (events.js:104:17)
44189 verbose cwd C:\Nightscout
44190 error Windows_NT 10.0.14393
44191 error argv "C:\\Program Files\\nodejs\\\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "--msvs_version=2013"
44192 error node v0.12.10
44193 error npm  v2.14.9
44194 error unexpected eof
44195 error If you need help, you may report this error at:
44195 error     <https://github.com/npm/npm/issues>
44196 verbose exit [ 1, true ]

@sulkaharo
Copy link
Member

I recall Heroku refuses to run without forever?

@PieterGit
Copy link
Contributor Author

@jaylagorio Thanks for testing. I will probably work on this PR this weekend.

@sulkaharo Running PieterGit@2d763c6 without forever since Jun 24 (~10 days) without problems, so that does not seem to be a problem. According to https://www.toptal.com/nodejs/top-10-common-nodejs-developer-mistakes it's Mistake #10: Not Using Supervisor Programs. I was hoping Heroku will be able to restart dynos by it selves.

Removing help wanted for now. First want to see if the downgrade of the packages fixes the memory ordering problems on dev.

@jaylagorio
Copy link
Contributor

@PieterGit Just drop me a heads up here when you've added commits I can pull down! This weekend should work for me for testing.

@PieterGit
Copy link
Contributor Author

@jaylagorio fixed this with #3675
Can you please confirm that Windows support is working for you?
Note that I also added some documentation in the README

@PieterGit PieterGit changed the title Make Nightscout run on Windows Remove forever and dependencies giving warnings on Windows Jul 8, 2018
@PieterGit PieterGit modified the milestones: 0.10.3, 0.11.0 Jul 8, 2018
@PieterGit
Copy link
Contributor Author

Removing forever is postponed until the 0.11 release

@jaylagorio
Copy link
Contributor

Confirmed npm install works and Nightscout loads! Thank you!

@PieterGit
Copy link
Contributor Author

Implemented removal of forever with #3721. Closing this PR

@PieterGit PieterGit closed this Jul 28, 2018
@PieterGit PieterGit modified the milestones: 0.11.0, 0.10.3 Jul 28, 2018
@PieterGit PieterGit deleted the 201806_windows branch December 24, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants