add node 0.12 to travis #415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,14 +1,12 @@ | |||
| language: node_js | |||
| sudo: false | |||
There was a problem hiding this comment.
A tweak to allow Travis to start up faster. More info here.
| @@ -29,7 +29,7 @@ | |||
| "postinstall": "node node_modules/bower/bin/bower install" | |||
| }, | |||
| "engines": { | |||
| "node": "~0.10.0" | |||
| "node": "0.10.x" | |||
There was a problem hiding this comment.
Equivalent, just switching to the prevailing style. I assume we want to do more thorough testing before adding or switching to "0.12.x".
|
|
||
| travis: test travis-cov |
There was a problem hiding this comment.
Redundant – it's not necessary to separate testing and generating the coverage report.
| allow_failures: | ||
| - node_js: "0.11" | ||
| - "0.10" | ||
| - "0.12" | ||
| services: | ||
| - mongodb | ||
| before_script: | ||
| - sleep 10 | ||
| - echo mongo mongo_travis |
There was a problem hiding this comment.
Just curious – what is this supposed to do?
There was a problem hiding this comment.
Maybe left over from testing the Travis setup? @bewest?
dduugg
force-pushed
the
wip/travis
branch
2 times, most recently
from
7adef4f
to
650074b
Compare
|
Need a new PR that targets dev too, since we're only updating master with releases |
|
Abandoning to target dev branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #414. Also includes some travis-related cleanup, cutting the Travis build time in half (to <1 minute under normal load).