Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip/enable is optional #511

Merged
merged 7 commits into from
Mar 23, 2015
Merged

Wip/enable is optional #511

merged 7 commits into from
Mar 23, 2015

Conversation

bewest
Copy link
Member

@bewest bewest commented Mar 22, 2015

Pebble crashes if there's no default value set.

  • ENABLE should not be required.
  • also env.head is used by mqqt and also needs a value: in dokku it needs to be set manually because the deployed asset is actually the output for git archive, not an actual git repo.

This helps with heroku and other non-azure hosts.
Found that the parameters didn't work as advertised unless done like
this.
Dokku doesn't have git repo as root.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.09% when pulling 4cfcb30 on wip/ENABLE-is-optional into 8889ceb on dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.09% when pulling 4cfcb30 on wip/ENABLE-is-optional into 8889ceb on dev.

Introduce forever.js
Conflicts:
	package.json
@bewest
Copy link
Member Author

bewest commented Mar 22, 2015

Also add forever.js for heroku, dokku and anyone else using Procfile.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 71.03% when pulling ff60b64 on wip/ENABLE-is-optional into 8889ceb on dev.

@bewest bewest added this to the enchilada milestone Mar 22, 2015
@jasoncalabrese
Copy link
Member

Tested with a fresh heroku deploy

jasoncalabrese added a commit that referenced this pull request Mar 23, 2015
@jasoncalabrese jasoncalabrese merged commit 28e42c2 into dev Mar 23, 2015
@jasoncalabrese jasoncalabrese deleted the wip/ENABLE-is-optional branch March 23, 2015 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants