Update virtual assistants v2 #5137
Conversation
Update 2019-05-08
|
@tanja3981 I've added some missing usage of |
|
@PieterGit @sulkaharo Other than @tanja3981 we don't seem to be getting a lot of feedback on this. :-( Would it be appropriate to request for a few individuals in the "CGM In the Cloud" FB group to help test it, and write up a quick instruction set for those who don't normally do dev testing? |
|
@inventor96 sorry for the lag! Any additional testing would be great - I personally don't have a Home or Alexa device and am a bit useless in real world testing of this |
|
@sulkaharo I don't know if you've been watching the post in the FB group, but a handful of people have volunteered to help test. Is there a deadline I should give them (conditional upon me resolving any issues they find) so we can keep this moving forward? |
|
@inventor96 This is one of the last things we could merge in to get the next release done, so the sooner the better. I don't think there's need to have a hard deadline, but if you can get some people to test this asap so we get a feel of how much polish / fixes there are and thus a potential timeline for when this is finished, that'd be great. <3 |
| @@ -242,108 +89,67 @@ After you enable testing, you can also use the Alexa Simulator in the left colum | |||
|
|
|||
There was a problem hiding this comment.
Indicate on the above lines somewhere (line 235-241). You can not type the keyword "Alexa" in the devloper console Test tab. This will confuse the alexa simulator. Instead just type out "Ask night scout how I am doing"
There was a problem hiding this comment.
Not a bad idea...
There was a problem hiding this comment.
It took me two days to figure this out. I believe if you use a mic and ask "Alexa, ask night scout how I am doing" It also gets confused. I was just copying and pasting from the suggested commands, which does not work.
|
@inventor96 I am fairly new to github, and since there is no way to PM on github. I have to ask a "dumb" question. How can I merge your branch into my current branch? I know how to do it usually, but your branch is not displayed on the master. |
|
@bennettnicholas Check out these instructions I've sent to members of the "CGM in the Cloud" Facebook group: https://docs.google.com/document/d/1v8EAbg7P7P_t-k2lOkZyUz7A7TpZmagq-ofma48FG4E/edit?usp=sharing It's probably not the best way to do it, but it allows people to test the branch without the need to run git commands on the repo locally on a computer. If you're comfortable using git on your computer, I believe you would add a remote that points to my repo, create a new branch in your local repo, then fetch and merge this PR into that new branch. (Disclaimer: it's been a while since I've done this, so you might do some Googling to confirm those steps) |
|
@sulkaharo Over the past two weeks, I've had 3 Alexa users and 1 Google Assistant user try out this PR (with a couple more that haven't responded yet), and the only issues reported have not been related to the code; just things like their chosen skill/action name is hard for their virtual assistant to recognize. Do you have an NS version name I can add to the Google Assistant documentation and then the PR can be merged? |
|
Issues
======
- Added 2
Complexity increasing per file
==============================
- lib/api/index.js 1
- lib/api/googlehome/index.js 4
- lib/api/alexa/index.js 8
- lib/plugins/googlehome.js 6
Complexity decreasing per file
==============================
+ lib/plugins/alexa.js -1
See the complete overview on Codacy |
|
I'm currently testing the Google home version and it connects well and communicates well thus far. I'm going to branch it to my phone so I can use it remotely as well as at home. |
|
Testing with google home works very well! I love it! |
|
@sulkaharo @PieterGit We're now up to 3 on each platform that have confirmed successful results. Do we have version name for 0.13? And then this PR can be merged? |
Second try after tests failed with #4980. This time the branch is rebased off of the
devbranch.