Ensure that HIGH and LOW values are reported when using share2bridge #7207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using share2nightscout-bridge, the device property is defined as 'share2' displayBg should honour the Dexcom HIGH and LOW values when the device is share2 This ensures that NightScout returns "LOW" for 39mg/dl and "HIGH" for 401mg/dl as is reported in the Dexcom app/receiver.
cpitchford
force-pushed
the
wip/cpitchford/support_high_low_share2_device
branch
from
b9c8950
to
8d83617
Compare
|
Thank you very much for this and the mmol enhancement! Including for next release. |
|
Awesome! Thanks for merging. I’d like to get my local changes merged in so I can take up the request for testing. Sadly, I’ve been running an older version (without problem) and tweaking as I went. It’ll be good to get back to master/dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dexcom apps/receivers report HIGH for 401mg/dl and LOW for 39mg/dl
When using share2nightscout-bridge, the device is set as "share2" and this corrects the code so it can display HIGH and LOW for these limit values when received.
Without this, the high and low values are reported numerically and differently to the Dexcom app/receiver