Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare release 14.2.6, development area post 14.2.5 release #7237

Merged
merged 60 commits into from
Sep 30, 2022
Merged

Conversation

bewest
Copy link
Member

@bewest bewest commented Dec 10, 2021

There are several features in dev branch needed for expected operation.

  • Data rights management - Obscuring the data source restores interoperability among data brokers choosing to discriminate. This has been in production use at T1Pal for 6 months.
  • Next version of Loop (likely 3.0.0) - Verified @ps2 - required for Loop 3.0 remote real-time sharing features.
  • Eliminate crash/NPE for AndroidAPS 3.. Verified @MilosKozak, @samihusseingit - required for 14.2.4+ compatibility with AAPS 3.0.
  • Proper and formal support for LTS Node versions. (We are delaying removing support for older Node until the next version to create an easier upgrade pathway for some users.)

samihusseingit and others added 30 commits November 3, 2019 19:11
This helps create an area for developing towards the next version.
Allow users to choose whether or not to reveal the provenance of the data to
consumers.  This is intended to help protect data rights to portability and
access.  If consumers start abusing or discriminating against Nightscout users
due to the source of the data, this allows users to conceal this information.
Disregard brand of device when considering glucose values.  By de facto usage,
the meaning of LOW and HIGH within Nightscout means that glucose is beyond limits.
LOW means 40 or lower.  HIGH means 400 or higher.  Both tend to invite
questioning therapy options, including inspecting if the device is working
correctly, as well as potential treatment options.
The results to render may come from an in-memory cache, or from the database.
If they came from the in-memory cache, it's possible that obscurring the device
field could actually change the values in memory.  When obscurring, the device
field, this patch copies all of the values in order to ensure that the
in-memory copies are unaffected.  With this patch, cached objects should not be
affected.
With this change, any code referencing the sandbox or /api/v2/properties for
plugin will also benefit from having the device information obscured.
…/cgm-remote-monitor into wip/bewest/obscure-provenance
Temporarily use git references to share2nightscout-bridge and
minimed-connect-to-nightscout in order to help test similar changes in those
packages.
The tests pass cleanly.
Run tests also against nodejs 16.x
@bewest
Copy link
Member Author

bewest commented Jun 30, 2022

There are several features in dev branch needed for expected operation.

  • Data rights management - Obscuring the data source restores interoperability among data brokers choosing to discriminate. This has been in production use at T1Pal for 6 months.
  • @ps2 - Will these changes be required for Loop 3.0 remote real-time sharing features?
  • @MilosKozak, @samihusseingit - These changes are required for 14.2.4+ compatibility with AAPS 3.0.

Should we consider bumping the version to something other than 14.2.6?
In addition, I'd like to adopt https://www.npmjs.com/package/express-slow-down to replace the delay feature currently implemented order to handle the valid case where browsers send multiple concurrent requests. The default delay breaks when behind a Nightscout-aware identity and access management router such as https://github.com/t1pal/nightscout-roles-gateway.

@bewest
Copy link
Member Author

bewest commented Jul 11, 2022

Here's an attempt at implementing express-slow-down: #7469

npm ls fsevent didn't list any output.  I'm running on linux,
and regenerating this file after removing it seems to remove
the fsevent package from the file.
It's likely that fsevent may be used in development mode as part
of one of the build utilities, but it shouldn't block anyone from
deploying.

#7475
The build still fails for node 12.x.
Skip optional dependencies.

https://stackoverflow.com/a/48953213
@ps2
Copy link
Contributor

ps2 commented Jul 18, 2022

@bewest Yes, Loop 3.0 will require these features.

@ps2
Copy link
Contributor

ps2 commented Jul 18, 2022

Actually, testing the dev branch again, I notice a significant bug, and filed a PR to fix it here: #7488

bewest and others added 9 commits July 18, 2022 11:21
Fix incorrect appending for loop enacted status. LGTM.
Remove npm list from engine as it is intended to be advisory.
This makes the testing framework and the advertised node versions match, one
for one.
Allow Remote Carb Entries in Past or Future
@bewest bewest mentioned this pull request Aug 14, 2022
@bewest bewest requested a review from sulkaharo August 18, 2022 17:20
@bewest
Copy link
Member Author

bewest commented Aug 18, 2022

@sulkaharo Let's release this as 14.2.6, the subsequent version will then target 15.0.0.
#7514

@bewest bewest changed the title prep development area post 14.2.5 release prepare release 14.2.6, development area post 14.2.5 release Aug 27, 2022
* Build docker image for arm64 architecture

* Add `platforms` input

* Merge `master` and `dev` jobs together into one

* Run job on master or dev branch
@bewest bewest merged commit 0bf616b into master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants