Support automatic bolus volumes in the enacted field for loop status. #7385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bewest, let me know if there is anything I can do to get this merged, or if there are any concerns that are preventing it from being merged. Thanks! Also, #7380, and #7375 are waiting as well, and I think I've addressed all comments. Or let me know if I should be talking to @MilosKozak or @sulkaharo, or someone else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With automatic bolusing in Loop, the last temp basal adjustment might be quite old. The current loop plugin only shows last temp basal adjustment. This change updates the plugin to show automatic bolus enactments in the loop pill as well, so the user has a clearer understanding of the time that Loop last adjusted dosing.
This must be merged before ps2/NightscoutService#17 can land in Loop.