Wip/bewest/daytoday redo 02 #7849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Bump jsonwebtoken from 8.5.1 to 9.0.0 (#7787)" This rolls back changes to node_modules via package-lock.json as a result of new dependencies. More work is needed before involving these changes. Without this rollback, the tests do consistently complete within the allowed time in a reproducible way.
Midnight for the profile should always be at the start of the day (midnight) for the chart.
This more closely mirrors logic in loopalyzer, as well as the intent from the surrounding code in reportclient.js.
This fixes the label on the days in the daytoday charts. Passing a moment object that is already zoned prevents toLocaleDateString from reinterpreting the zone information when the date is already relative to the profile. This also ensures that the datefilter is adjusted to the profile's zone rather than truncating the time to the end or beginning of the day. This should prevent incorrectly wrapping arounnd the dateline.
To illustrate the difference, I used chrome "sensors" feature to change my
timezone to one that spans the dateline.
> moment.tz('2023-01-19', 'America/Los_Angeles').endOf('day').format( )
'2023-01-19T23:59:59-08:00'
> moment.tz(moment('2023-01-19'), 'America/Los_Angeles').endOf('day').format( )
'2023-01-18T23:59:59-08:00'
The old code uses a string replacement, which is equivalent to the first
test. This causes the dates on the reports to be off by one, as well as
risks the data wrapping around the dateline so it can't be seen. For example,
replacing "23:59:59" with "00:00:00" in the first example doesn't correctly
wrap around the dateline.
The patch introduces a way to parse the dates requested in the browser's
time zone, and then translates them to the profile's timezone. The
difference is shown in the second example above. With this change, the
correct date label should be rendered, and the data should start at
midnight without wrapping around the dateline.
Ensure that the test fixtures will return; the previous changes correctly forward the time to end of day across zones and datelines. One side effect is that the date formatted for the end of the day uses all the microseconds for the day as well. This changes the query from the form of 23:59:59.000Z to 23:59:59.999Z. This also ensures that anything that happens during that one second will be included rather than excluded.
|
closing in favor of #7857 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a happier version of 01750cf