rename smbIsAlwaysOff to smbIsScheduledOff

[MikePlante1]

More importantly, it reverts the swapping of smbIsOff and smbIsAlwaysOffsmbIsScheduledOff

Must be merged in tandem with nightscout/Trio#120

[mountrcg]

To me it look there is only small things off, pun intended. In OiAPS the two variables should be switched:

Text	Variable
Disable SMB's	smbIsOff
Schedule when SMB's are off	smbIsScheduledOff

And if smbIsScheduledOff gets toggled to true, the smbIsOff must toggle false. If that is done the oiref code should be fine.

… edited to reflect variable name change

[MikePlante1]

To me it look there is only small things off, pun intended. In OiAPS the two variables should be switched:

Text Variable
Disable SMB's smbIsAlwaysOff
Schedule when SMB's are off smbIsOff
And if smbIsOff get toggled to true, the smbIsAlwaysOff should become false. If that is done the oiref code should be fine.

Yes, that would make more sense. I’ll put together a PR for the Oi repo instead and close this one.

[MikePlante1]

@mountrcg If we're changing them anyway, I think smbIsScheduledOff would be a better name than smbIsOff

[bjornoleh]

@mountrcg If we're changing them anyway, I think smbIsScheduledOff would be a better name than smbIsOff

Agreed, that's a more descriptive name for that variable. I'll take another look later if you are changing this PR or creating another in OiAPS?

[MikePlante1]

@bjornoleh It will require a PR to the Oi repo, but I'm not sure if I'll open a new one or just modify this one to match the updated variable names.

EDIT: I don't think I'll get to it today, but will definitely get it done by tomorrow (4/17).

[JeremyStorring]

Everything here looks good to me. I agree with the variable renames

[bjornoleh]

I agree that this looks good, and I have successfully tested this in OiAPS too.