Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISF value in enacted pop-up "pill" shows only final ISF #186

Closed
MRMProd opened this issue May 14, 2024 · 9 comments
Closed

ISF value in enacted pop-up "pill" shows only final ISF #186

MRMProd opened this issue May 14, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@MRMProd
Copy link

MRMProd commented May 14, 2024

Describe the bug
In the pop-up pill ISF value shows final ISF two times, "ISF: 2.2 > 2.2"

To Reproduce
Steps to reproduce the behavior:

  1. Enable an Override with adjustment to ISF
  2. Click on loop symbol to bring up the pill..'
  3. See error

Expected behavior
correct should be in my example "ISF:3.0 > 2.2"

Screenshots
IMG_54F0D4D19230-1

  • Trio version, branch and git reference (see Trio Settings)
    v0.1.0
@JeremyStorring JeremyStorring added the bug Something isn't working label May 15, 2024
@JeremyStorring JeremyStorring added this to the Trio 1.0 release milestone May 18, 2024
@bjornoleh
Copy link
Contributor

I think this is feature and not bug. The ISF value is adjusted according to the override, but dynamic ISF or autosens is still able to adjust ISF on top of this, which would show up as the ISF value at the right hand side of the arrow.

I think this issue can be closed as not being a bug?

@MRMProd
Copy link
Author

MRMProd commented May 30, 2024

Removed this post since update to latest solved some issues. But when enabling Dynamic CR or ISF it is not showing the dynamic adjustments in the pill? That must still be a bug not showing final ISF/CR? Final ISF/CR are not shown in log file either? Little confused with "EnableDynamicISF" called "useNewFormula" now

@dnzxy
Copy link
Contributor

dnzxy commented May 30, 2024

@MRMProd could you please provide a more verbose list of steps of what exactly you are doing and what outcome you see but that isn’t along the lines of what you would expect to be true.

I must admit I am having a bit of trouble to follow what you are trying to see with which settings under which context where - log and or loop status hud 🤔

@MRMProd
Copy link
Author

MRMProd commented May 30, 2024

If enabling dynamic ISF and/or dynamic CR nothing shows in the pill?
IMG_7731
IMG_7733 the scheduled ISF are 3

@MRMProd
Copy link
Author

MRMProd commented May 30, 2024

Here are an old 2.3.3 with Dynamic ISF and CR enabled
415976157_10231599999165778_1142577532351990099_n 2

@dnzxy
Copy link
Contributor

dnzxy commented May 30, 2024

Have there been >1 loop cycles between you enabling it and looking at the hud? Sorry for asking seemingly weird question, just trying to get all details of what you do and what the expected outcome is.

@MikePlante1
Copy link
Contributor

@MRMProd Your 2.3.3 screenshot shows that DynamicISF is being used with Sigmoid off (all the purple blocks) and that Autosens has been calculated by DynamicISF to be 0.7.

Your Trio screenshot however, does not show DynamicISF being used at all, and Autosens is set to 1, therefore both X and Y in X->Y are the same.

Like @dnzxy mentioned, the HUD only changes after a loop cycle is ran, so toggling on Dynamic ISF (and CR) won't affect the HUD until the next loop cycle runs.

But also, has Trio been running for 21+ hours with a real pump and cgm attached to it? Because DynamicISF requires a minimum of 21 hours of insulin data to run.

@MikePlante1
Copy link
Contributor

MikePlante1 commented May 30, 2024

Little confused with "EnableDynamicISF" called "useNewFormula" now

I agree that name is not great, but that's what it was called in iAPS 2.3.3, and looks like it's still called that in the latest iAPS 4.2.0

@MRMProd
Copy link
Author

MRMProd commented May 31, 2024

Everything seems to work now, you can close this "bug". Most of the issue was 21+ hours making the display not showing correctly. One thing I can add to enhancement is changing the name in the pill from Autosense Ratio to Dynamic Ratio when dynamic is used. This is confusing for new users when they think it is autosense but in reality is dynamic ratio (when dynamic is used). I did get Jon to change that in the new version just to clarify for new users. Sorry for taking up time from you guys but is was really strange before 21 hrs + used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

6 participants