Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated broken examples in nightwatch-v2 #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Updated broken examples in nightwatch-v2 #7

wants to merge 1 commit into from

Conversation

nothuman2718
Copy link

@nothuman2718 nothuman2718 commented Feb 27, 2024 •
edited
Loading

Overview of this PR.

  1. There are some flaky tests for those I added pause() for some time.
  2. For some examples I used this link.
  3. There is example on dragAndDrop(). The method is not working well. Please look into it.
  4. For most of the examples logic is correct, so I only changed what is needed.
    Closes Outdated ChromeDriver version in package.json #6

If any further changes or modifications are required. Please let me know. I will work on it.

@nothuman2718 nothuman2718 changed the title Fixed examples. # Fixed examples. Mar 1, 2024
garg3133
garg3133 reviewed Mar 18, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
garg3133
garg3133 reviewed Mar 18, 2024
View reviewed changes
package-lock.json Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json should ideally not contain these many changes for a single dependency change. Can you look into it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes are due to
npm audit fix
current
Screenshot 2024-03-19 at 12 05 26 AM
this PR
Screenshot 2024-03-19 at 12 10 07 AM

Copy link
Author

@nothuman2718 nothuman2718 Mar 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct fix. I guess.
When I think about this PR, I realise that package.json is generated when we do npm i, and modifying that does not fix vulnerabilities.
Can you say how we can proceed?

garg3133
garg3133 reviewed Mar 18, 2024
View reviewed changes
tests/guide/duckDuckGo.js Outdated Show resolved Hide resolved
@nothuman2718 nothuman2718 changed the title Fixed examples. Updated broken examples in nightwatch-v2 Mar 21, 2024
@nothuman2718
Copy link
Author

@garg3133 Can you review this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garg3133 garg3133 Awaiting requested review from garg3133

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Outdated ChromeDriver version in package.json
2 participants
@nothuman2718 @garg3133