Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightwatch throws error when selenium.log_path is false or undefined. #17

Closed
doctyper opened this issue Feb 4, 2014 · 2 comments
Closed
Assignees
Labels

Comments

@doctyper
Copy link

doctyper commented Feb 4, 2014

This line expects a value or it throws an error:

❯ ./nightwatch
Starting selenium server... started - PID:  6967
Running tests

[ sample module ]

Running:  Demo test Google
Setting up...
✔  Element <body> was visible after 148 milliseconds.
✔  Element <button[name=btnG]> was visible after 13 milliseconds.
✔  Testing if element <#main> contains text: The Night Watch
Tearing down...
OK. 3 assertions passed.

path.js:360
        throw new TypeError('Arguments to path.join must be strings');
              ^
TypeError: Arguments to path.join must be strings
    at path.js:360:15
    at Array.filter (native)
    at Object.exports.join (path.js:358:36)
    at ChildProcess.closeHandler (/test/nightwatch-test/node_modules/nightwatch/runner/run.js:122:23)
    at ChildProcess.EventEmitter.emit (events.js:98:17)
    at maybeClose (child_process.js:735:16)
    at Process.ChildProcess._handle.onexit (child_process.js:802:5)

The workaround, of course, is to add some value to the configuration file:

{
    "selenium" : {
        "log_path" : "tests"
    },
}
@beatfactor beatfactor added the bug label Feb 4, 2014
@beatfactor beatfactor self-assigned this Feb 4, 2014
@beatfactor
Copy link
Member

thanks, I'll fix that.

@beatfactor
Copy link
Member

this was fixed in 511c126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants