Fix global reporting in parallel mode (fixes #1205)

[aberonni]

This is an attempt at fixing #1205 - I have fixed the original bug but some tests are failing and I cannot understand why. The test output is not very verbose and it does not point me in any direction.

Also I would have like to add a test case that reproduces the original bug but was not able to.

I'm opening this as WIP because I need some pointers

[lreading]

I don't fully understand the "why" as of yet, but it looks like the global-reporter is getting an undefined reporter passed to the constructor. The reporter param is actually supposed to be a string representing either a path to a reporter, or the name of a built-in reporter.

As a workaround for the failing tests, you could change line 26 in global-reporter.js to say:
this.reporterFile = reporter || 'junit'; // Default the reporter to junit if one is not provided

This will make the tests pass, but it is a bit of a hack. I don't fully understand how the code paths work yet, so it's hard for me to say why that is happening.

[aberonni]

@lreading thanks for the tip, I'll wait for @beatfactor to chip in on this, he might be able to confirm your hypothesis

[stale]

This issue has been automatically marked as stale because it has not had any recent activity.
If possible, please retry using the latest Nightwatch version and update the issue with any relevant details. If no further activity occurs, it will be closed. Thank you for your contribution.

[aberonni]

Not stale, @beatfactor please take a look whenever you can - not sure whether this is still relevant with the latest version. If it could be then I will rebase

[aberonni]

@beatfactor I've rebased the branch and included the fix mentioned by @lreading above. It looks like it is working, and I cannot reproduce the bug anymore after testing 1206 here.

I tried adding a test case for the bug I'm fixing but didn't manage to, maybe it will be easier for you or you can point me in the right direction

[beatfactor]

this.reportResults() returns a Promise so we should wait for it.

Suggested change

	this.reportResults();
	return this.reportResults().then(hasFailures => {
	return exitCode
	})