Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use locate strategy from args when valid strategy is found #2716

Conversation

gravityvi
Copy link
Member

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

Related Issues

@gravityvi gravityvi requested a review from beatfactor May 23, 2021 19:03
@gravityvi gravityvi changed the title use local strategy from args when valid strategy is found use locate strategy from args when valid strategy is found May 23, 2021
@gravityvi gravityvi marked this pull request as draft May 24, 2021 09:57
@gravityvi gravityvi marked this pull request as ready for review May 24, 2021 11:12
@gravityvi gravityvi requested a review from beatfactor May 24, 2021 11:12
@beatfactor beatfactor merged commit dd46144 into nightwatchjs:main May 25, 2021
@gravityvi gravityvi deleted the issue/2695-waitFor-setStrategy-from-args branch May 26, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xpath locators stopped working for .waitForElementVisible() and .waitForElementPresent()
2 participants