fix: xml output generation for parallel tests #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatfactor
reviewed
Jun 9, 2021
lib/reporter/global-reporter.js
Outdated
| @@ -51,7 +51,7 @@ module.exports = class GlobalReporter { | |||
| setupChildProcessListener(emitter) { | |||
| const Concurrency = require('../runner/concurrency/concurrency.js'); | |||
|
|
|||
| if (Concurrency.isMasterProcess()) { | |||
| if (Concurrency.isMasterProcess() || Concurrency.isChildProcess()) { | |||
There was a problem hiding this comment.
shouldn't we remove the check altogether?
There was a problem hiding this comment.
Yes, we should, but I wasn't sure, why the check exists in the first place. Let me update the PR
There was a problem hiding this comment.
This check is for the scenario when running in parallel with test workers. A child process will send the results back to the main process. When running tests across multiple browsers, the results aren't called by the main process anymore so it doesn't work (since the bug), so we need to make sure that the test workers scenario still works well.
There was a problem hiding this comment.
we can probably just change the check to !Concurrency.isTestWorker()
|
Need to add test here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2728
Overview
XML output files are not generated when running parallel tests on multiple browsers, because when we run concurrent tests, we only check the master process to push the results to the 'GlobalReporter', but in fact, the tests are spawn through the child process.