remove node promise rejection in case of error #2797
Conversation
| @@ -77,7 +77,6 @@ class AsyncTree extends EventEmitter{ | |||
| let abortOnFailure = false; | |||
|
|
|||
| if (result instanceof Error) { | |||
| node.reject(result); | |||
There was a problem hiding this comment.
was this added recently, and something that was working fine before?
Because i believe the issue reported is a regression right ?
There was a problem hiding this comment.
No this was not added recently but as and when the node promise is rejected, the user needs to handle the rejection in the script or the scripts ends in between.
There was a problem hiding this comment.
Okay, I am confused, the issue raised is a regression, meaning it was working fine until some change that we did. So user hasnt changed their script, they just upgraded the version right ?
There was a problem hiding this comment.
Yes, perhaps I need to dig up further how the rejection was being handled in previous versions.
There was a problem hiding this comment.
Well, whatever it is, it's fixed. Great work Ravi :)
| timeout: 15, | ||
| retryInterval: 15 | ||
| }); | ||
| await client.verify.elementPresent('#weblogin'); |
There was a problem hiding this comment.
how about if we chain these?
Changes
Impact